Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plot widget to bottom #1199

Merged
merged 10 commits into from Dec 21, 2023
Merged

Move plot widget to bottom #1199

merged 10 commits into from Dec 21, 2023

Conversation

ahuang11
Copy link
Collaborator

Builds on top of #1198 for more screen space for the plot and partially addresses #1190

image

@ahuang11 ahuang11 changed the base branch from main to explorer_widget_width November 12, 2023 06:17
@ahuang11 ahuang11 changed the title Move explorer widget to bottom Move plot widget to bottom Nov 14, 2023
Base automatically changed from explorer_widget_width to main December 10, 2023 21:31
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't exactly know why but it doesn't fit very well in a notebook output cell. Do you interact with the explorer always as an app? I'd guess the explorer is more used in a notebook context.

image

When served as an app the plot occupies the whole space and the widget box looks a little alone centered down there.

image

What alternative do we have? We could maybe dynamically create a new tab populated with the widget box? Or add it below the groupby multiselect?

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Dec 11, 2023

A floating pane or built into Bokeh's toolbar if ever possible like for HoloNote eventually.

@ahuang11
Copy link
Collaborator Author

Oh I suppose we could do widget_layout = pn.Row instead of pn.Column.

@ahuang11
Copy link
Collaborator Author

image

@ahuang11
Copy link
Collaborator Author

Another thing we need to fix is the default legend_loc.

),
sizing_mode='stretch_both'
sizing_mode='stretch_width',
height=600
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min_height unfortunately did not work for me.

@maximlt
Copy link
Member

maximlt commented Dec 21, 2023

image

The widgets are not well vertically aligned, I don't think we can merge with this issue, let's see if I can fix it.

@maximlt
Copy link
Member

maximlt commented Dec 21, 2023

Came up with a workaround:
image

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explorer will look much better with this change when there are multiple widgets!

@ahuang11
Copy link
Collaborator Author

Shall we merge?

@maximlt
Copy link
Member

maximlt commented Dec 21, 2023

Yes, I was waiting for the tests to pass.

@maximlt maximlt merged commit c8efb3e into main Dec 21, 2023
8 checks passed
@maximlt maximlt deleted the move_widget branch December 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants