Require HoloViews>=1.19.0, bump other dependencies, and drop Python 3.8 #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 87.39% 88.41% +1.01%
==========================================
Files 50 50
Lines 7490 7360 -130
==========================================
- Hits 6546 6507 -39
+ Misses 944 853 -91 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hvPlot's dependencies haven't been updated in a long time. HoloViews 1.19.0 just got released with a pretty major change with how it handles Pandas indexes that should bring some great performance benefits. We decided it'd be easier to just start depending on that new version, instead of adding code to ensure compatibility with older versions. Since HoloViews 1.19.0 also bumped its dependencies, hvPlot upgrades its own dependencies with these updates.