Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken test due to PROJ unexpectedly matching 'foo' #660

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Sep 10, 2021

Fixes #657

The code uses PROJ under the hood that matches 'foo' with a projection named 'Amersfoort'. Replaced by 'name_of_some_invalid_projection' which doesn't match and should never match any projection in the future.

@coveralls
Copy link

coveralls commented Sep 10, 2021

Coverage Status

Coverage increased (+2.8%) to 71.589% when pulling 52e3e70 on fix_test_pyproj_crs_matching into 00e1ceb on master.

hvplot/tests/testgeo.py Outdated Show resolved Hide resolved
Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>
@jbednar jbednar merged commit 5c41b81 into master Sep 13, 2021
@jbednar jbednar deleted the fix_test_pyproj_crs_matching branch September 13, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on Python 3.7 due to CRS interpretation
3 participants