Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the expected DataSet plot title after xarray 2022.6.0 #795

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 24, 2022

One test started to fail after the release of xarray 2022.6.0 a couple of days ago. The title set to a plot made from an xarray object is defined by relying on an internal xarray function, this was added in #659. Apparently something changed in xarray, I actually didn't see any obvious change in the particular function that was called so that may be at another level, anyway the scalar coords displayed in the title are not ordered in the same way after the last release. In the failing test 'y = 0, x = 0, time = 0, band = 0' was replaced by 'time = 0, y = 0, x = 0, band = 0'. The former, i.e. the newer title, appears to be more accurate as respecting the order of the coords declared in one of the original DataArray:

coords={'time': [0, 1], 'y': [0, 1], 'x': [0, 1], 'band': [0, 1]},

I've simply updated the test to not fail with the newest releases of xarray, and still pass with the older ones.

@maximlt
Copy link
Member Author

maximlt commented Jul 25, 2022

Merging, it's a minor change to the test suite that reflects that hvplot is in line with the output of the .plot API of xarray, and it's preventing other test runs to pass.

@maximlt maximlt merged commit ce0f4e1 into master Jul 25, 2022
@maximlt maximlt deleted the update_test_xarray_202260 branch July 25, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant