Remove the marker styling option of the explorer#809
Merged
Conversation
Collaborator
|
You could maybe try using the |
Member
Author
|
Thanks Jean-Luc for pointing at this dict, it may be useful in the future but I think for now I'll merge this PR, a lot more work is required before styling is made possible in the explorer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort of fixes #786
The explorer had a
markerstyling option available that in practice wasn't useful as it was not listing the markers available, in light of the upcoming release this PR simply removes this option.Handling the styling options is a lot trickier than the other plot options:
markercan accept. I don't think HoloViews does either, @jlstevens do you confirm?. And I don't know if the plotting backends have APIs that expose their allowed values.It seems like there's more thinking and work required before exposing styling options to the explorer. My take is that for a first release the explorer is already useful enough without the styling options, hence this PR.