Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the marker styling option of the explorer #809

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 29, 2022

Sort of fixes #786

The explorer had a marker styling option available that in practice wasn't useful as it was not listing the markers available, in light of the upcoming release this PR simply removes this option.

Handling the styling options is a lot trickier than the other plot options:

  • they vary given the selected backend
  • they vary given the select kind of plot
  • hvPlot for sure doesn't know anything about the values a styling option like marker can accept. I don't think HoloViews does either, @jlstevens do you confirm?. And I don't know if the plotting backends have APIs that expose their allowed values.
  • there can be many many options to set, in particular for the interactive backends

It seems like there's more thinking and work required before exposing styling options to the explorer. My take is that for a first release the explorer is already useful enough without the styling options, hence this PR.

@jlstevens
Copy link
Collaborator

You could maybe try using the markers dictionary here https://github.com/holoviz/holoviews/blob/master/holoviews/plotting/bokeh/styles.py#L45 that has the marker styles that map between Bokeh and Matplotlib.

@maximlt
Copy link
Member Author

maximlt commented Aug 3, 2022

Thanks Jean-Luc for pointing at this dict, it may be useful in the future but I think for now I'll merge this PR, a lot more work is required before styling is made possible in the explorer.

@maximlt maximlt merged commit 84ebf35 into master Aug 3, 2022
@maximlt maximlt deleted the explorer_remove_marker branch August 3, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvPlotExplorer issues with Style pane
2 participants