New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display selected custom view parameters as widgets #124
Comments
I vote for all 3. People should be able to declare parameters as constant, and if they do, then why show them? Supporting 2 just seems like correct behavior. Same for 1 -- the mechanism is already there, and respecting it seems fully appropriate. 3 is an option that is probably useful and convenient, so it doesn't have to be supported but does seem like a good idea. If all 3 are supported, the question becomes which mechanism we promote and explain as the appropriate or typical way. I'll leave that call to Philipp; it's really about storytelling and narrative and pitching, so it's best to have one voice for that (Philipp). |
I agree that constant parameters probably don't need widgets. I suppose I would encourage people to use option 3 but if no explicit list is given, the fallback should be option 2 (with option 1 applying as well). |
Honestly I think popping up a bunch of parameters (or rather widgets) by default is surprising and I'm not sure you can always decide ahead of time which parameters it makes sense to expose so I'm leaning towards 3. as the main mechanism here. But if that is the main mechanism I'm having a hard time seeing what supporting options 1. and 2. would add here or how that would even work. |
I see you settled on an explicit |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This issue summarizes some discussion I've had with @philippjfr and @jbednar about how best to generate widgets for custom view parameters. Here are the three options we talked about:
constant=True
for the parameters that shouldn't be shown as widgets.Personally, I like option 3 the most as it is the most explicit and lets you easily set the widget order in the yaml. Then I like option 1 as it is consistent with how panel displays widgets for parameters and I like option 3 the least.
The text was updated successfully, but these errors were encountered: