Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to manually apply updates #330

Merged
merged 3 commits into from Sep 27, 2022
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 27, 2022

Adds a manual_update option to the global config, each Target and Pipeline to be able to manually update the data using a button click. This is useful when applying a filter or transform is very slow.

apply_update

  • Add tests
  • Decide on naming of manual_update parameter

@droumis
Copy link
Member

droumis commented Sep 27, 2022

When needing this manual update button, the user is trying to prevent auto-updates, so I could see the parameter being something like auto_update: False

@philippjfr
Copy link
Member Author

Think I prefer that over manual_update, thanks.

@philippjfr philippjfr merged commit 617ae3b into master Sep 27, 2022
@philippjfr philippjfr deleted the manual_update branch September 27, 2022 12:29
@maximlt
Copy link
Member

maximlt commented Sep 27, 2022

Just adding some comments as I recently worked on a similar thing on a Panel app. The app was only doing filtering so I called it live_filtering. The UI I thought implementing (I didn't have to in the end) was a combination of a check box and a button, to either enabling live filtering (the button would then be disabled) or disabling it in which case you have to click on the button to execute the filters and update the view.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants