Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger events manually if setting model attribute does not #132

Merged
merged 2 commits into from Oct 30, 2018

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 30, 2018

The need for this fix arises from the difference in the way the comm based syncing and bokeh server work. On bokeh server bokeh model properties are always synced between frontend and backend, which means that if a value changes it knows whether that value has changed. When communicating via comms no such syncing occurs and we have to trigger a message no matter what.

@philippjfr philippjfr changed the title Trigger events manually if setting them does not Trigger events manually if setting model attribute does not Oct 30, 2018
@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #132 into master will increase coverage by 0.2%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #132     +/-   ##
=========================================
+ Coverage   89.68%   89.88%   +0.2%     
=========================================
  Files          27       27             
  Lines        4120     4153     +33     
=========================================
+ Hits         3695     3733     +38     
+ Misses        425      420      -5
Impacted Files Coverage Δ
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/util.py 79.31% <100%> (+4.9%) ⬆️
panel/viewable.py 70.04% <85.71%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e3f43...1377ce1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

widget callback issue
2 participants