-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextToSpeech Widget #1878
TextToSpeech Widget #1878
Conversation
Would be happy to merge this, but let's call it |
I like the TextToSpeech name. Have been thinking the same. The reason why I did not do it is that 1) the HTML version is called speechSynthesis and 2) there is also SpeechSynthesisUtterance and SpeechSynthesisVoice objects defined and used. Would you you rename those additional objects to Utterance and Voice as well? I like that for simplicity and specificity. But we loose the reference to the original objects. Like renaming Tabulator to Table. 🙂 |
I've renamed to TextToSpeech, Utterance and Voice respectively. |
Note: I'm currently refactoring as requested. This includes changing the So I will also add a speak action. |
I believe I have implemented review feedback. Next step is on you @philippjfr . Let me know if there is more I should do. Thx. |
A few more comments:
if (a == b)
doSomething() not if (a == b) {
doSomething()
}
|
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
+ Coverage 84.85% 84.90% +0.05%
==========================================
Files 154 160 +6
Lines 19128 19522 +394
==========================================
+ Hits 16231 16576 +345
- Misses 2897 2946 +49
Continue to review full report at Codecov.
|
I think this could be a nice addition to Panel and provide some nice use cases. I hope you (@philippjfr ) will think so as well.
It might not be within "Data Viz" but for exploring and testing out ideas and working with machine learning or just developing small tools it can be really nice. And for me Panel is about data, models and analytics including AI and DL.
It is READY for review. I can't find any more bugs or things to improve for my use cases.
You can checkout how it works in the video on discourse https://discourse.holoviz.org/t/speech-synthesis/1631