Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeechToText Widget #1880

Merged
merged 25 commits into from
Feb 15, 2021
Merged

SpeechToText Widget #1880

merged 25 commits into from
Feb 15, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jan 1, 2021

Preliminary SpeechToTextWidget.

I've implemented, test and created parts of a Notebook. The functionality seems to be there.

But I need to learn and improve from some more advanced examples. And finalize the notebook.

The PR is showcased here https://discourse.holoviz.org/t/happy-new-year-w-speechtotext-widget-pr/1637. This includes a video of it.

FYI. @philippjfr

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Jan 1, 2021

The Reference Notebook is now ready for review. I identified some bugs and fixed them while developing.

I hope to develop an example for the Gallery to further learn about and test the widget.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Jan 2, 2021

FYI. @philippjfr

I have finalized the implementation and testing. This includes adding an additional notebook to the Gallery.

I don't plan to do anything more on this before I get feedback from review or users.

@MarcSkovMadsen
Copy link
Collaborator Author

The gallery notebook is "demoed" here https://discourse.holoviz.org/t/texttospeech-example-pr/1646

@philippjfr
Copy link
Member

Three comments:

  1. Needs to be rebased
  2. Indentation in .ts files should be 2 spaces
  3. A few flake errors (just add # noqa)

@MarcSkovMadsen
Copy link
Collaborator Author

Regarding the 3 flake "line too long errors" they do not make sense. As you can see below the line is NOT too long. Thus there is nothing I can fix. @philippjfr

image

@MarcSkovMadsen
Copy link
Collaborator Author

I've fixed what I can fix (see flake comment above).

I have run panel build panel and use bokeh==2.3.0.dev12 but now I get an error when I run python -m panel serve 'panel\tests\widgets\test_speech_to_text.py' --dev --show.

Error rendering Bokeh items: TypeError: c is not a constructor

image

My hypothesis is that it has nothing to do with this PR.

Next step is on you @philippjfr . Let me know if there is more I can/ shall do?

@philippjfr
Copy link
Member

Thanks, I'll take a look.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1880 (63c0688) into master (035c81b) will decrease coverage by 0.34%.
The diff coverage is 85.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   85.21%   84.87%   -0.35%     
==========================================
  Files         152      157       +5     
  Lines       18981    19360     +379     
==========================================
+ Hits        16175    16432     +257     
- Misses       2806     2928     +122     
Impacted Files Coverage Δ
panel/widgets/__init__.py 100.00% <ø> (ø)
panel/widgets/speech_to_text.py 78.57% <78.57%> (ø)
panel/tests/widgets/test_speech_to_text.py 90.72% <90.72%> (ø)
panel/models/speech_to_text.py 100.00% <100.00%> (ø)
panel/widgets/button.py 83.78% <100.00%> (ø)
panel/reactive.py 71.17% <0.00%> (-14.93%) ⬇️
panel/widgets/file_selector.py 85.09% <0.00%> (-4.27%) ⬇️
panel/layout/tabs.py 86.02% <0.00%> (-1.48%) ⬇️
panel/widgets/tables.py 83.33% <0.00%> (-1.30%) ⬇️
panel/compiler.py 10.00% <0.00%> (-1.12%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035c81b...63c0688. Read the comment docs.

@philippjfr philippjfr merged commit b70ec65 into master Feb 15, 2021
@philippjfr philippjfr deleted the speech-to-text branch February 15, 2021 13:29
@philippjfr
Copy link
Member

Thanks @MarcSkovMadsen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants