-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added general support for linking Panel objects #199
Conversation
ccbab6e
to
ff62eb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 90.12% 90.08% -0.04%
==========================================
Files 31 33 +2
Lines 4942 5176 +234
==========================================
+ Hits 4454 4663 +209
- Misses 488 513 +25
Continue to review full report at Codecov.
|
0edc7d7
to
5edb7e7
Compare
5edb7e7
to
9dc9644
Compare
9dc9644
to
8a0424d
Compare
@xavArtley I've started generalizing the LinkCallback a bit so we can eventually apply arbitrary linking. Next I'll be adding a simpler API to specify widget links. Please let me know if you disagree with any of my changes so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2326fda
to
64900ca
Compare
d4f2f14
to
76270f3
Compare
@xavArtley I've once again refactored the code in order to make linking a completely general concept which can be applied both in Python and in JS. Have a look at the updated Links.ipynb to see what you think. @jbednar When you get a minute I'd appreciate it if you could review and edit that notebook as well to see what you think. |
76270f3
to
20d1b88
Compare
@philippjfr Great work it's very intuitive. |
@philippjfr, that looks great! I've reworked that a bit:
|
@philippjfr, that looks great! I've reworked the Links.ipynb notebook a bit:
|
If those changes look ok to you, I'm happy to merge it! |
@xavArtley If you're around could you apply the suggestions? Only the PR author can do it. |
Co-Authored-By: xavArtley <xavart2011@gmail.com>
Co-Authored-By: xavArtley <xavart2011@gmail.com>
Thanks @xavArtley at working out the initial cut of this and thanks @jbednar for tidying up the docs. |
Following PR #191
It focus only on the Links between widgets and Hv bokeh plots
I removed
AxesLink
which was a link between Hv bokeh plotsI removed dependencies to holoviews (duplicate code of the
Link
class of holoviews)I will create another PR with some refactor of the links between Hv Plots to decorrelate Links from holoviews and links developed in Panel.