Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Viewer baseclass #2045

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Provide Viewer baseclass #2045

merged 5 commits into from
Mar 2, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 2, 2021

Provides a Viewer baseclass which can be used to make custom components viewable (i.e. provide .servable, .show and _repr_mimebundle_ methods. A user just has to implement __panel__.

Closes #1979
Fixes #1981
Fixes #1980

@philippjfr philippjfr changed the title Provide ViewableWrapper baseclass Provide Viewer baseclass Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2045 (448b0cc) into master (20617c8) will decrease coverage by 0.36%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
- Coverage   84.30%   83.93%   -0.37%     
==========================================
  Files         178      178              
  Lines       20612    20203     -409     
==========================================
- Hits        17377    16958     -419     
- Misses       3235     3245      +10     
Impacted Files Coverage Δ
panel/pane/base.py 90.38% <50.00%> (-1.56%) ⬇️
panel/viewable.py 71.64% <63.63%> (-0.35%) ⬇️
panel/pipeline.py 88.63% <75.00%> (-0.09%) ⬇️
panel/tests/pane/test_base.py 87.09% <0.00%> (-12.91%) ⬇️
panel/config.py 46.15% <0.00%> (-5.79%) ⬇️
panel/auth.py 36.51% <0.00%> (-3.37%) ⬇️
panel/pane/ipywidget.py 47.05% <0.00%> (-2.95%) ⬇️
panel/io/reload.py 63.95% <0.00%> (-2.72%) ⬇️
panel/io/callbacks.py 54.16% <0.00%> (-2.42%) ⬇️
panel/tests/template/test_manual.py 60.63% <0.00%> (-2.37%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20617c8...448b0cc. Read the comment docs.

@philippjfr philippjfr merged commit 16db42b into master Mar 2, 2021
@philippjfr philippjfr deleted the viewable_wrapper branch March 2, 2021 12:52
xavArtley pushed a commit that referenced this pull request Mar 9, 2021
@MarcSkovMadsen
Copy link
Collaborator

This is great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot layout Pipeline Pipeline is not servable Provide ParameterizedComponent
2 participants