Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement array input #2047

Merged
merged 11 commits into from Feb 11, 2022
Merged

Implement array input #2047

merged 11 commits into from Feb 11, 2022

Conversation

xavArtley
Copy link
Collaborator

fix #1977

array_input

philippjfr
philippjfr reviewed Mar 2, 2021
View reviewed changes
panel/widgets/input.py Outdated Show resolved Hide resolved
@xavArtley
Copy link
Collaborator Author

I made a mistake I remove the format correction

@philippjfr
Copy link
Member

I'm a little worried about merging this, what happens when you put in a 1000x1000 array?

@philippjfr
Copy link
Member

Having the ArrayInput is fine but not guarding for the size of the array when doing the widget mapping seems like it might be problematic.

@xavArtley
Copy link
Collaborator Author

Indeed it can only be used to edit small arrays

jbednar
jbednar reviewed Mar 8, 2021
View reviewed changes
panel/widgets/input.py Outdated Show resolved Hide resolved
panel/widgets/input.py Outdated Show resolved Hide resolved
@xavArtley
Copy link
Collaborator Author

array_inputt

@xavArtley xavArtley added status: WIP type: discussion Requiring community discussion in progress and removed status: WIP labels Mar 9, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2022 •
edited

Codecov Report

Merging #2047 (602d1f0) into master (d1cb469) will increase coverage by 0.02%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   82.96%   82.99%   +0.02%     
==========================================
  Files         193      193              
  Lines       25574    25621      +47     
==========================================
+ Hits        21217    21263      +46     
- Misses       4357     4358       +1
Impacted Files Coverage Δ
panel/param.py 86.83% <ø> (ø)
panel/widgets/__init__.py 100.00% <ø> (ø)
panel/widgets/input.py 96.33% <96.87%> (+0.04%) ⬆️
panel/tests/widgets/test_input.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cb469...602d1f0. Read the comment docs.

@philippjfr philippjfr added type: enhancement Minor feature or improvement to an existing feature and removed type: discussion Requiring community discussion labels Feb 11, 2022
@philippjfr philippjfr added this to the v0.13.0 milestone Feb 11, 2022
@philippjfr philippjfr merged commit 33f4a14 into master Feb 11, 2022
@philippjfr philippjfr deleted the xav/array_input branch February 11, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr left review comments

@jbednar jbednar jbednar left review comments

Assignees
No one assigned
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Parse problems when mapping param.Array() to a widget
3 participants
@xavArtley @philippjfr @jbednar