Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling of template resources #2076

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix bundling of template resources #2076

merged 2 commits into from
Mar 12, 2021

Conversation

philippjfr
Copy link
Member

Fixes two issues with bundling:

  1. Bundle resources shared by multiple Templates into baseclass bundle directory
  2. Ensure template bundle directories are consistently lowercased

Fixes #2074

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2076 (5d084d4) into master (650c9e7) will increase coverage by 0.00%.
The diff coverage is 53.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2076   +/-   ##
=======================================
  Coverage   84.40%   84.41%           
=======================================
  Files         178      179    +1     
  Lines       20646    20723   +77     
=======================================
+ Hits        17427    17494   +67     
- Misses       3219     3229   +10     
Impacted Files Coverage Δ
panel/compiler.py 7.17% <0.00%> (-0.35%) ⬇️
panel/template/base.py 80.33% <100.00%> (+0.47%) ⬆️
panel/tests/pane/test_perspective.py 100.00% <0.00%> (ø)
panel/pane/perspective.py 91.80% <0.00%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c9e7...5d084d4. Read the comment docs.

@philippjfr philippjfr merged commit 2a913e2 into master Mar 12, 2021
@philippjfr philippjfr deleted the fix_bundler branch March 12, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still cannot deploy panel apps on binder. Static - Assets not found
1 participant