Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value_throttled in pn.depends decorator #2085

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Fix value_throttled in pn.depends decorator #2085

merged 4 commits into from
Mar 15, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 15, 2021

Fixes #2082

Todo

  • Before merge I need to check if this affect pn.depends in parameterized classes. Update: This fix is also needed to get value_throttled to work in a parameterized classes.
  • Check if other widgets have value_throttled. Update: IntInput and FloatInput.

@nghenzi can you double check if this fixes all the sliders problems?
@philippjfr I have taken the liberty to remove value_throttled from __repr__ to avoid confusion. I will do the todo later today, but you can take over the PR if you need to release 0.11.1 before that and want to include this.

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2085 (e3815af) into master (f133c3f) will decrease coverage by 0.00%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
- Coverage   84.43%   84.43%   -0.01%     
==========================================
  Files         179      179              
  Lines       20757    20769      +12     
==========================================
+ Hits        17526    17536      +10     
- Misses       3231     3233       +2     
Impacted Files Coverage Δ
panel/widgets/input.py 95.26% <71.42%> (-0.58%) ⬇️
panel/widgets/slider.py 94.40% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f133c3f...e3815af. Read the comment docs.

@nghenzi
Copy link
Contributor

nghenzi commented Mar 15, 2021

I think It works now.

fix_throttled.mp4

Only to be sure. I am not sure if the procedure was ok, I installed the fix_throttled branch with

pip install git+https://github.com/Hoxbro/panel.git@fix_throttled

and I tried the sliders. The fact I do not understand is when I do "conda list panel" the version package is

image

The committ number is ok, but the panel version no.

@hoxbro
Copy link
Member Author

hoxbro commented Mar 15, 2021

The most important thing is the commit number. Thank you for the help :)

@philippjfr
Copy link
Member

Looks good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None of the sliders support value_throttled in pn.depends decorator
3 participants