Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting root_directory on FileSelector widget #2086

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

philippjfr
Copy link
Member

Closes #2051

@philippjfr philippjfr changed the title File select root Allow setting root_directory on FileSelector widget Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2086 (58a5a4c) into master (650c9e7) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   84.40%   84.39%   -0.02%     
==========================================
  Files         178      179       +1     
  Lines       20646    20764     +118     
==========================================
+ Hits        17427    17523      +96     
- Misses       3219     3241      +22     
Impacted Files Coverage Δ
panel/widgets/file_selector.py 84.52% <72.72%> (-0.57%) ⬇️
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/base.py 90.61% <0.00%> (-0.94%) ⬇️
panel/compiler.py 7.17% <0.00%> (-0.35%) ⬇️
panel/tests/test_depends.py 100.00% <0.00%> (ø)
panel/tests/pane/test_perspective.py 100.00% <0.00%> (ø)
panel/template/base.py 80.33% <0.00%> (+0.47%) ⬆️
panel/depends.py 83.82% <0.00%> (+0.49%) ⬆️
panel/pane/perspective.py 91.80% <0.00%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c9e7...58a5a4c. Read the comment docs.

@philippjfr philippjfr merged commit 437491d into master Mar 15, 2021
@philippjfr philippjfr deleted the file_select_root branch March 15, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow FileSelector widget to browse outside of initialized path
1 participant