Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out NamedListLike baseclass #2127

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Factor out NamedListLike baseclass #2127

merged 3 commits into from
Mar 29, 2021

Conversation

philippjfr
Copy link
Member

Makes the inheritance hierarchy a little nicer allowing other components to inherit NamedListLike behavior without explicitly subclassing the NamedListPanel class, which also includes a lot of functionality related to rendering child models.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #2127 (692b2be) into master (4904cfd) will decrease coverage by 0.02%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
- Coverage   84.50%   84.47%   -0.03%     
==========================================
  Files         182      182              
  Lines       21272    21301      +29     
==========================================
+ Hits        17975    17995      +20     
- Misses       3297     3306       +9     
Impacted Files Coverage Δ
panel/layout/base.py 90.20% <90.32%> (-0.05%) ⬇️
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/pane/base.py 87.89% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4904cfd...692b2be. Read the comment docs.

@philippjfr philippjfr merged commit 9c8ee73 into master Mar 29, 2021
@philippjfr philippjfr deleted the named_list_like branch March 29, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant