Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divide by zero issues on Trend indicator #2148

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

philippjfr
Copy link
Member

Fixes #2146

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2148 (f07f712) into master (31b5350) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
- Coverage   83.81%   83.78%   -0.04%     
==========================================
  Files         182      182              
  Lines       21672    21672              
==========================================
- Hits        18165    18157       -8     
- Misses       3507     3515       +8     
Impacted Files Coverage Δ
panel/widgets/indicators.py 94.83% <100.00%> (ø)
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/base.py 87.89% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b5350...f07f712. Read the comment docs.

@philippjfr philippjfr merged commit 56ce69c into master Apr 8, 2021
@philippjfr philippjfr deleted the trend_divide_zero branch April 8, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator Widget Encounters RuntimeError from Divide by Zero
1 participant