Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabulator sorting and data initialization #2163

Merged
merged 1 commit into from Apr 12, 2021
Merged

Conversation

philippjfr
Copy link
Member

  • Fixes sorting of unpaginated table
  • Fixes data initialization of unpaginated table

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2163 (beffeb6) into master (e8f3324) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
- Coverage   83.82%   83.79%   -0.04%     
==========================================
  Files         182      182              
  Lines       21773    21773              
==========================================
- Hits        18252    18244       -8     
- Misses       3521     3529       +8     
Impacted Files Coverage Δ
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/base.py 87.89% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f3324...beffeb6. Read the comment docs.

@philippjfr philippjfr merged commit fb73018 into master Apr 12, 2021
@philippjfr philippjfr deleted the tabulator_fixes branch April 12, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant