Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and standardize selection behavior of Tabulator #2230

Merged
merged 5 commits into from
Apr 22, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 22, 2021

The old table had a more intuitive selection behavior which used Ctrl/Meta keys to toggle selection of multiple rows and the shift key for range selection. The Tabulator has a default behavior where clicking on rows simply toggles selection on and off. This changes the Tabulator selection behavior to be consistent with the old behavior but also allowing users to toggle the previous behavior by setting selectable='toggle'.

Fixes #2089

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2230 (06aece8) into master (6af7bb5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
- Coverage   83.66%   83.66%   -0.01%     
==========================================
  Files         182      182              
  Lines       21866    21868       +2     
==========================================
+ Hits        18295    18296       +1     
- Misses       3571     3572       +1     
Impacted Files Coverage Δ
panel/models/tabulator.py 100.00% <100.00%> (ø)
panel/widgets/tables.py 84.26% <100.00%> (+0.05%) ⬆️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af7bb5...06aece8. Read the comment docs.

@philippjfr philippjfr merged commit fbe2e2e into master Apr 22, 2021
@philippjfr philippjfr deleted the tabulator_select branch April 22, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation of select for tabulator widget
1 participant