Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save_layout parameter to ReactTemplate #2296

Merged
merged 8 commits into from
Jun 2, 2021
Merged

Add save_layout parameter to ReactTemplate #2296

merged 8 commits into from
Jun 2, 2021

Conversation

syamajala
Copy link
Contributor

Add a parameter to save layout changes to localStorage for ReactTemplate.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #2296 (2e1faff) into master (a6dbf03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2296   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         181      181           
  Lines       22064    22066    +2     
=======================================
+ Hits        18557    18559    +2     
  Misses       3507     3507           
Impacted Files Coverage Δ
panel/template/react/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dbf03...2e1faff. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented May 9, 2021

It would be really nice to have the FastGridTemplate updated as well. They are normally kept in sync. At some stage they should be refactored and share the same code if possible.

@philippjfr
Copy link
Member

Thanks @syamajala. The main thing I'm wondering about is how we can save the layout per dashboard, e.g. if I deploy two different dashboards using the ReactTemplate will the layout settings for one persist for the other? Do we need to work out some mechanism to hash each application to allow multiple layout persistence. The simplest would be to simply hash it on the application title but other suggestions welcome.

@philippjfr
Copy link
Member

Actually hashing on the URL would make the most sense.

@philippjfr
Copy link
Member

@syamajala Anything I can do to help here?

@syamajala
Copy link
Contributor Author

This should use the url for saving layouts now.

@philippjfr philippjfr merged commit 0c40980 into holoviz:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants