-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add save_layout parameter to ReactTemplate #2296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 181 181
Lines 22064 22066 +2
=======================================
+ Hits 18557 18559 +2
Misses 3507 3507
Continue to review full report at Codecov.
|
It would be really nice to have the |
Thanks @syamajala. The main thing I'm wondering about is how we can save the layout per dashboard, e.g. if I deploy two different dashboards using the ReactTemplate will the layout settings for one persist for the other? Do we need to work out some mechanism to hash each application to allow multiple layout persistence. The simplest would be to simply hash it on the application title but other suggestions welcome. |
Actually hashing on the URL would make the most sense. |
@syamajala Anything I can do to help here? |
This should use the url for saving layouts now. |
Add a parameter to save layout changes to localStorage for ReactTemplate.