Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap new gallery examples into apps #2546

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Wrap new gallery examples into apps #2546

merged 2 commits into from
Mar 23, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jul 20, 2021

I just checked out the index page on Binder and I can see the new gallery examples are in the index but do not display anything. Will try to solve

Todo

  • CanvasDraw
  • LeafletHeatMap
  • [] MaterialUI

@MarcSkovMadsen
Copy link
Collaborator Author

CanvasDraw

image

I struggled a bit because the height of the canvas is set to the height of the panel. I.e. there is no remaining height left for the buttons. Furthermore I tried to apply sizing_mode='stretch_width' but could not get it working.

I would have wished the buttons where not a part of the template. But instead Panel buttons. That would have made the example more useful on how to build components in general I believe.

@MarcSkovMadsen
Copy link
Collaborator Author

LeafletHeatMap

My experience is that it reacts quickly to changes in sliders in notebook but slower/ slowly when wrapped in template.

leaflet-heatmap.mp4

@philippjfr
Copy link
Member

Will just merge for consistency. Cleanup can happen later.

@philippjfr philippjfr merged commit 7a630d6 into master Mar 23, 2022
@philippjfr philippjfr deleted the binder-gallery-apps branch March 23, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants