Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for bool in parse_query #2759

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Added check for bool in parse_query #2759

merged 2 commits into from
Sep 21, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 19, 2021

Fixes #2758

TODO:

  • Write/update a unittest

@hoxbro hoxbro changed the title Added check if bool in query Added check for bool in parse_query Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #2759 (ae81ad0) into master (80a66c3) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
+ Coverage   82.03%   82.66%   +0.63%     
==========================================
  Files         187      188       +1     
  Lines       23963    24056      +93     
==========================================
+ Hits        19658    19887     +229     
+ Misses       4305     4169     -136     
Impacted Files Coverage Δ
panel/tests/test_util.py 100.00% <100.00%> (ø)
panel/util.py 82.78% <100.00%> (+1.38%) ⬆️
panel/tests/command/test_serve.py 85.00% <0.00%> (ø)
panel/tests/conftest.py 95.90% <0.00%> (+0.21%) ⬆️
panel/pane/holoviews.py 79.65% <0.00%> (+0.21%) ⬆️
panel/pane/vtk/vtk.py 96.83% <0.00%> (+0.45%) ⬆️
panel/pane/plot.py 59.69% <0.00%> (+0.51%) ⬆️
panel/pane/vega.py 82.64% <0.00%> (+0.82%) ⬆️
panel/io/callbacks.py 68.00% <0.00%> (+1.00%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a66c3...ae81ad0. Read the comment docs.

@philippjfr philippjfr merged commit 8dd7fa7 into holoviz:master Sep 21, 2021
@philippjfr
Copy link
Member

Thanks @hoxbro !

philippjfr pushed a commit that referenced this pull request Sep 24, 2021
* Added check for bool in parse_query

* Added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync location does not work with checkbox
2 participants