Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cleanup happens when enabling --warm or --autoreload with Bokeh 2.4 #2760

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2755

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #2760 (b3cf204) into master (dd8aeca) will increase coverage by 0.61%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   82.03%   82.65%   +0.61%     
==========================================
  Files         187      188       +1     
  Lines       23963    24049      +86     
==========================================
+ Hits        19658    19877     +219     
+ Misses       4305     4172     -133     
Impacted Files Coverage Δ
panel/tests/command/test_serve.py 85.00% <85.00%> (ø)
panel/command/serve.py 39.56% <100.00%> (+22.52%) ⬆️
panel/tests/conftest.py 95.90% <100.00%> (+0.21%) ⬆️
panel/pane/holoviews.py 79.65% <0.00%> (+0.21%) ⬆️
panel/pane/vtk/vtk.py 96.83% <0.00%> (+0.45%) ⬆️
panel/pane/plot.py 59.69% <0.00%> (+0.51%) ⬆️
panel/pane/vega.py 82.64% <0.00%> (+0.82%) ⬆️
panel/io/callbacks.py 68.00% <0.00%> (+1.00%) ⬆️
panel/viewable.py 70.44% <0.00%> (+2.06%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8aeca...b3cf204. Read the comment docs.

panel/tests/command/test_serve.py Outdated Show resolved Hide resolved
panel/tests/command/test_serve.py Outdated Show resolved Hide resolved
panel/tests/command/test_serve.py Show resolved Hide resolved
panel/tests/command/test_serve.py Show resolved Hide resolved
@philippjfr philippjfr merged commit af2728f into master Sep 20, 2021
@philippjfr philippjfr deleted the autoreload_fix_bk_2.4 branch September 20, 2021 11:49
@hoxbro
Copy link
Member

hoxbro commented Sep 20, 2021

I'm seeing some (new) problems with this fix.

I have this code

import panel as pn
pn.panel("Test").servable()

Which I run with panel serve race_condition.py --autoreload, but when I reload the page multiple times I get this error:

2021-09-20 22:06:31,569 DocumentLifeCycleHandler on_session_destroyed callback <bound method PeriodicCallback._cleanup of PeriodicCallback(callback=functools.partial(<function _reload_on_update at 0x00000250A9488AF8>, {'race_condition.py': 1632167947.1386704}), count=None, name='PeriodicCallback00196', period=500, running=False, timeout=None)> failed with following error: 'DocumentCallbackManager' object has no attribute '_change_callbacks'

Screenshot
2021-09-20 22_07_30

Screencast

Video.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: 'Document' object has no attribute '_callbacks'
3 participants