-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure cleanup happens when enabling --warm or --autoreload with Bokeh 2.4 #2760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
+ Coverage 82.03% 82.65% +0.61%
==========================================
Files 187 188 +1
Lines 23963 24049 +86
==========================================
+ Hits 19658 19877 +219
+ Misses 4305 4172 -133
Continue to review full report at Codecov.
|
d2abc5c
to
159c49d
Compare
I'm seeing some (new) problems with this fix. I have this code import panel as pn
pn.panel("Test").servable() Which I run with 2021-09-20 22:06:31,569 DocumentLifeCycleHandler on_session_destroyed callback <bound method PeriodicCallback._cleanup of PeriodicCallback(callback=functools.partial(<function _reload_on_update at 0x00000250A9488AF8>, {'race_condition.py': 1632167947.1386704}), count=None, name='PeriodicCallback00196', period=500, running=False, timeout=None)> failed with following error: 'DocumentCallbackManager' object has no attribute '_change_callbacks' Screencast Video.mp4 |
Fixes #2755