Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pn.viewable.Viewer can now be used with pn.serve #2769

Merged
merged 2 commits into from
Sep 22, 2021
Merged

pn.viewable.Viewer can now be used with pn.serve #2769

merged 2 commits into from
Sep 22, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 21, 2021

Resolves #2768

I don't know if there should be a more advanced unit test involving calling pn.serve.

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #2769 (3642463) into master (33894cd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2769      +/-   ##
==========================================
+ Coverage   82.73%   82.74%   +0.01%     
==========================================
  Files         188      188              
  Lines       24102    24112      +10     
==========================================
+ Hits        19941    19952      +11     
+ Misses       4161     4160       -1     
Impacted Files Coverage Δ
panel/pane/base.py 88.88% <100.00%> (+0.54%) ⬆️
panel/tests/test_viewable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33894cd...3642463. Read the comment docs.

@philippjfr philippjfr merged commit f7f2f69 into holoviz:master Sep 22, 2021
philippjfr pushed a commit that referenced this pull request Sep 24, 2021
* Added check if object is subclass of Viewer

* Added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pn.serve for pn.viewable.Viewer class
2 participants