Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GenericOAuthProvider configurable via env vars #2960

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

philippjfr
Copy link
Member

Adds support for:

  • PANEL_OAUTH_TOKEN_URL
  • PANEL_OAUTH_AUTHORIZE_URL
  • PANEL_OAUTH_USER_URL
  • PANEL_OAUTH_SCOPE
  • PANEL_USER_KEY

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2960 (325abc9) into master (3928b2f) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2960      +/-   ##
==========================================
- Coverage   83.13%   83.12%   -0.02%     
==========================================
  Files         190      190              
  Lines       24869    24871       +2     
==========================================
- Hits        20676    20673       -3     
- Misses       4193     4198       +5     
Impacted Files Coverage Δ
panel/auth.py 40.62% <22.22%> (-0.18%) ⬇️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3928b2f...325abc9. Read the comment docs.

@philippjfr philippjfr merged commit 15b7395 into master Nov 29, 2021
@philippjfr philippjfr deleted the oauth_env_vars branch November 29, 2021 18:36
@TheoMathurin
Copy link
Contributor

Just stumbled upon this. It's very helpful and IMO should be documented in the authentication section. I can submit a PR.

@philippjfr
Copy link
Member Author

That would be great, however I'm currently restructuring the docs entirely (see #4251). Maybe wait until I merge that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants