Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added direction to player #2970

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Added direction to player #2970

merged 1 commit into from
Dec 3, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 2, 2021

Exposing the direction parameter. xref https://discourse.holoviz.org/t/state-of-player-widget/3133

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #2970 (08c84d6) into master (e79a7b2) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   83.02%   83.12%   +0.09%     
==========================================
  Files         190      190              
  Lines       24737    24954     +217     
==========================================
+ Hits        20538    20742     +204     
- Misses       4199     4212      +13     
Impacted Files Coverage Δ
panel/widgets/player.py 83.05% <100.00%> (+0.29%) ⬆️
panel/models/vega.py 88.00% <0.00%> (-6.12%) ⬇️
panel/param.py 86.92% <0.00%> (-0.82%) ⬇️
panel/io/save.py 62.60% <0.00%> (-0.33%) ⬇️
panel/pane/image.py 80.50% <0.00%> (-0.23%) ⬇️
panel/auth.py 40.62% <0.00%> (-0.18%) ⬇️
panel/pane/plot.py 59.58% <0.00%> (-0.11%) ⬇️
panel/io/callbacks.py 66.66% <0.00%> (ø)
panel/models/layout.py 100.00% <0.00%> (ø)
panel/tests/test_util.py 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79a7b2...08c84d6. Read the comment docs.

@philippjfr philippjfr merged commit c582fd7 into holoviz:master Dec 3, 2021
@hoxbro hoxbro deleted the player_direction branch December 3, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants