New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alphabetical and custom sort to Param #2986
Conversation
Example from issueMuch easier to find something 😄 import panel as pn
import numpy as np
import holoviews as hv
pn.extension(sizing_mode="stretch_width")
template = pn.template.FastListTemplate(
site="Awesome Panel", title="New Accent Color",
main=[pn.widgets.Button(name="Click Me", button_type="primary")],
)
pn.Param(template, sorted=True).servable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I requested a few changes but overall I'll be very happy with this.
Thanks for your comments @philippjfr . I've fixed and pushed. There is one test failure. But I cannot see it should be related to these changes. Please let know if I should do more. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks!
The failed test was due to a corrupted dev release of holoviews (my bad!). This had been fixed very quickly. @MarcSkovMadsen feel free to push an empty commit to rerun the test suite. |
I've just restarted the test suite. |
1745d69
to
d87cb73
Compare
Codecov Report
@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
+ Coverage 83.25% 83.27% +0.02%
==========================================
Files 190 190
Lines 24971 25001 +30
==========================================
+ Hits 20789 20819 +30
Misses 4182 4182
Continue to review full report at Codecov.
|
Thanks @philippjfr, I always forget that the CI can be rerun (there should be a more obvious button but maybe that's intentional). |
Addresses #2985