Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ButtonGroup value when changing options #2999

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Update ButtonGroup value when changing options #2999

merged 4 commits into from
Dec 13, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 8, 2021

Fixes #2998

@hoxbro
Copy link
Member Author

hoxbro commented Dec 9, 2021

I have an idea of how to fix the failing test but don't know when I have time to take a look at it. So you can update/close this PR if necessary @philippjfr.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2999 (cc08dd9) into master (f5a099d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
+ Coverage   83.24%   83.26%   +0.01%     
==========================================
  Files         190      190              
  Lines       25014    25029      +15     
==========================================
+ Hits        20824    20840      +16     
+ Misses       4190     4189       -1     
Impacted Files Coverage Δ
panel/tests/widgets/test_select.py 100.00% <100.00%> (ø)
panel/widgets/select.py 94.36% <100.00%> (+0.28%) ⬆️
panel/widgets/player.py 80.00% <0.00%> (-3.06%) ⬇️
panel/models/reactive_html.py 79.57% <0.00%> (-0.71%) ⬇️
panel/tests/test_reactive.py 98.86% <0.00%> (+0.01%) ⬆️
panel/template/base.py 78.76% <0.00%> (+0.04%) ⬆️
panel/reactive.py 76.23% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a099d...cc08dd9. Read the comment docs.

@philippjfr
Copy link
Member

Fabulous, thank you!

@philippjfr philippjfr merged commit 90b272f into holoviz:master Dec 13, 2021
@hoxbro hoxbro deleted the CheckBoxSync branch December 13, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error displaying CheckBoxGroup after modifying it in a callback
2 participants