Fix issue serializing Spinner widgets with negative infinity value #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
changed the title
philippjfr
force-pushed
the
negative_inf_fix
branch
from
449e94a
to
a34d035
Compare
Codecov Report
@@ Coverage Diff @@
## master #3154 +/- ##
==========================================
- Coverage 82.99% 82.98% -0.02%
==========================================
Files 192 192
Lines 25482 25488 +6
==========================================
+ Hits 21150 21152 +2
- Misses 4332 4336 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix works because the Spinner widget cannot render infinite values anyway. So this successfully avoids the error. A change in bokeh would be needed to actually support rendering (and entering) positive/negative infinity values in the widget.
Fixes #1998