Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BooleanStatus and LoadingSpinner now updates when changing color #3191

Merged
merged 1 commit into from
Feb 11, 2022
Merged

BooleanStatus and LoadingSpinner now updates when changing color #3191

merged 1 commit into from
Feb 11, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 11, 2022

Fixes #3143

BooleanStatus.mp4
LoadingSpinner.mp4

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #3191 (79542f0) into master (6e627cb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
+ Coverage   82.95%   82.99%   +0.03%     
==========================================
  Files         192      193       +1     
  Lines       25529    25624      +95     
==========================================
+ Hits        21177    21266      +89     
- Misses       4352     4358       +6     
Impacted Files Coverage Δ
panel/widgets/indicators.py 92.15% <100.00%> (+0.05%) ⬆️
panel/widgets/base.py 94.66% <0.00%> (-0.08%) ⬇️
panel/param.py 86.83% <0.00%> (ø)
panel/config.py 61.29% <0.00%> (ø)
panel/widgets/__init__.py 100.00% <0.00%> (ø)
panel/tests/widgets/test_input.py 100.00% <0.00%> (ø)
panel/models/json_editor.py 83.33% <0.00%> (ø)
panel/widgets/input.py 96.33% <0.00%> (+0.04%) ⬆️
panel/widgets/misc.py 95.08% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e627cb...79542f0. Read the comment docs.

@philippjfr philippjfr merged commit 9d3c366 into holoviz:master Feb 11, 2022
@philippjfr
Copy link
Member

Thanks @hoxbro!

@hoxbro hoxbro deleted the enh_indicators branch February 11, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating BooleanStatus color doesn't work
2 participants