Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DatetimePicker start/end to param.Date #3202

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

philippjfr
Copy link
Member

A DatetimePicker should allow datetimes for the start and end values.

@hoxbro
Copy link
Member

hoxbro commented Feb 16, 2022

Just for reference see #3107 why it was not done in the first place.

@philippjfr
Copy link
Member Author

Thanks @hoxbro! Given that in most cases people just use datetime even when they really want a date I think I'm still going to allow this but document the limitation more clearly.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #3202 (2ab676b) into master (c796c02) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2ab676b differs from pull request most recent head 89b7546. Consider uploading reports for the commit 89b7546 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3202   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         193      193           
  Lines       25695    25695           
=======================================
  Hits        21367    21367           
  Misses       4328     4328           
Impacted Files Coverage Δ
panel/widgets/input.py 96.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c796c02...89b7546. Read the comment docs.

@philippjfr philippjfr merged commit b906e68 into master Mar 8, 2022
@philippjfr philippjfr deleted the datetime_picker_date_param branch March 8, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants