-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fullpath to jupyter_server_extension #3270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3270 +/- ##
==========================================
- Coverage 83.14% 83.13% -0.02%
==========================================
Files 195 195
Lines 26030 26031 +1
==========================================
- Hits 21643 21641 -2
- Misses 4387 4390 +3
Continue to review full report at Codecov.
|
This is great thank you! I notice you added a utility but aren't using it consistently yet. |
I only have it in Then I just searched for If you want, I can move the functions into a |
Seems sensible. |
@@ -160,7 +160,7 @@ def recurse_tree(path, excludes, opts): | |||
""" | |||
# use absolute path for root, as relative paths like '../../foo' cause | |||
# 'if "/." in root ...' to filter out *all* modules otherwise | |||
path = os.path.abspath(path) | |||
path = os.path.abspath(os.path.expanduser(path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outside the panel module so I chose to keep it.
Done. Just to be transparent, I have not changed lines where something like |
I noticed I couldn't get the Panel widget in jupyter lab to work in a non-base conda environment.
With the output in my terminal:
The error is because
~
is present in the path and whenos.path.abspath
is used it gives a wrong result.The
abspath
command is called from bokeh and a fix should be implemented there too.