Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datetime handling of sliders #3276

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Improve datetime handling of sliders #3276

merged 3 commits into from
Mar 29, 2022

Conversation

philippjfr
Copy link
Member

Previously the datetime handling of the DateRangeSlider did not correctly roundtrip datetime values unless you were in the UTC timezone. This would cause a bit of jitter because values coming from the frontend would boomerang causing the slider to reset to an earlier state.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #3276 (0f0d1dc) into master (73e6839) will increase coverage by 0.00%.
The diff coverage is 95.65%.

@@           Coverage Diff           @@
##           master    #3276   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files         195      195           
  Lines       26136    26151   +15     
=======================================
+ Hits        21764    21777   +13     
- Misses       4372     4374    +2     
Impacted Files Coverage Δ
panel/widgets/slider.py 84.16% <95.23%> (+0.43%) ⬆️
panel/util.py 85.09% <100.00%> (+0.11%) ⬆️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/tests/pane/test_plotly.py 98.15% <0.00%> (-0.62%) ⬇️
panel/io/state.py 69.11% <0.00%> (-0.23%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e6839...0f0d1dc. Read the comment docs.

@philippjfr philippjfr merged commit 2218cdc into master Mar 29, 2022
@philippjfr philippjfr deleted the dt_slider branch March 29, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant