Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DiscreteSlider label is updated #3278

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

philippjfr
Copy link
Member

Fixes #3275 and #2709

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #3278 (203250d) into master (2218cdc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3278   +/-   ##
=======================================
  Coverage   83.28%   83.29%           
=======================================
  Files         195      195           
  Lines       26156    26166   +10     
=======================================
+ Hits        21785    21794    +9     
- Misses       4371     4372    +1     
Impacted Files Coverage Δ
panel/tests/io/test_embed.py 99.41% <100.00%> (+0.01%) ⬆️
panel/widgets/slider.py 84.12% <100.00%> (-0.04%) ⬇️
panel/tests/pane/test_plotly.py 98.15% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2218cdc...203250d. Read the comment docs.

@philippjfr philippjfr merged commit 635c5c5 into master Mar 29, 2022
@philippjfr philippjfr deleted the discrete_slider_label branch March 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvplot.interactive: DiscreteSlider doesn't update when served by Panel
1 participant