Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align download property default values #3292

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 31, 2022

Fixes #2697

I'm not quite sure how to test .download().

@philippjfr
Copy link
Member

I'm not quite sure how to test .download().

Probably not going to get around setting up a selenium testing framework for Panel some time soon.

@philippjfr
Copy link
Member

Fix makes sense, thanks!

@philippjfr philippjfr merged commit cdf2bc9 into master Mar 31, 2022
@philippjfr philippjfr deleted the fix_tabulator_download branch March 31, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator download method does not work the first time
2 participants