Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator: allow to set selectable=1 #3295

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 31, 2022

Addresses #3074

By just removing the default value of True of the select_mode model property as suggested in the issue which indeed allows to declare that only 1 row can be selected.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #3295 (b22e451) into master (1559e72) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files         195      195           
  Lines       26374    26374           
=======================================
  Hits        21980    21980           
  Misses       4394     4394           
Impacted Files Coverage Δ
panel/models/tabulator.py 94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1559e72...b22e451. Read the comment docs.

@philippjfr philippjfr merged commit 7810c1e into master Apr 1, 2022
@philippjfr philippjfr deleted the allow_select_1_row branch April 1, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants