Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable max row limits for Tabulator #3306

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

philippjfr
Copy link
Member

This PR automatically toggles pagination to either 'local' or 'remote' if it was not explicitly set and the number of rows in the table exceed certain limits. The default limit for local' pagination is 200 and for 'remote' pagination is 10,000.

Fixes #2841

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #3306 (ea88c0c) into master (db8e0ac) will increase coverage by 0.01%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
+ Coverage   83.36%   83.38%   +0.01%     
==========================================
  Files         196      196              
  Lines       26486    26500      +14     
==========================================
+ Hits        22081    22096      +15     
+ Misses       4405     4404       -1     
Impacted Files Coverage Δ
panel/widgets/tables.py 87.78% <78.57%> (-0.14%) ⬇️
panel/io/callbacks.py 84.03% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8e0ac...ea88c0c. Read the comment docs.

@philippjfr philippjfr merged commit 80d90ee into master Apr 4, 2022
@philippjfr philippjfr deleted the table_max_row_limit branch April 4, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator needs a max row default protection
1 participant