Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to indicators #3359

Merged
merged 4 commits into from
Apr 10, 2022
Merged

Add docstrings to indicators #3359

merged 4 commits into from
Apr 10, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

The docstrings make it so much easier to use the widgets in an IDE like VS Code.

image

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #3359 (4d85435) into master (4d4afb7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4d85435 differs from pull request most recent head 37b7693. Consider uploading reports for the commit 37b7693 to get more accurate results

@@           Coverage Diff           @@
##           master    #3359   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files         196      196           
  Lines       26607    26607           
=======================================
  Hits        22156    22156           
  Misses       4451     4451           
Impacted Files Coverage Δ
panel/widgets/indicators.py 92.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d4afb7...37b7693. Read the comment docs.

@philippjfr philippjfr merged commit 3179c1b into master Apr 10, 2022
@philippjfr philippjfr deleted the indicator-docstrings branch April 10, 2022 09:52
@MarcSkovMadsen
Copy link
Collaborator Author

Thanks for wrapping the docstrings @philippjfr . Could you enlighten me why you do it? (I would like to know such that you don't have to do it).

I normally work with a max -line-length of 100 and I can see Panels flake8 rule is 165

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants