Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EditableSlider updates when no value_throttled is set #3387

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3371

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #3387 (bd944a7) into master (d1385fb) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
- Coverage   82.95%   82.93%   -0.03%     
==========================================
  Files         198      198              
  Lines       26982    26980       -2     
==========================================
- Hits        22384    22376       -8     
- Misses       4598     4604       +6     
Impacted Files Coverage Δ
panel/widgets/slider.py 84.10% <0.00%> (-0.75%) ⬇️
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/io/state.py 69.11% <0.00%> (-0.23%) ⬇️
panel/io/server.py 78.09% <0.00%> (-0.22%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️
panel/io/callbacks.py 75.93% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1385fb...bd944a7. Read the comment docs.

@philippjfr philippjfr merged commit 520b0e3 into master Apr 14, 2022
@philippjfr philippjfr deleted the editable_slider_error branch April 14, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditableRangeSlider TypeError in _sync_start_value
1 participant