New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to test Panel data apps #4244
Conversation
AssetsSome assets used in the docs that should later be uploaded to a cdn. app.mp4 app.mp4app.gif uitest.mp4 uitest.mp4uitest.gif panel-playwright-recording.mp4 panel-playwright-recording.mp4panel-playwright-recording.gif panel-locust.mp4 panel-locust.mp4panel-locust.gif loadwright.mp4 loadwright.mp4loadwright.gif |
Hi @philippjfr Please make a first draft review. I need some feedback on the overall outline and content. As a minimum I would appreciate feedback on:
|
My initial reaction is that this is indeed a lot of content for a single guide. I'd suggest splitting it into at least two guides:
|
Codecov Report
@@ Coverage Diff @@
## main #4244 +/- ##
==========================================
- Coverage 83.05% 82.71% -0.35%
==========================================
Files 237 237
Lines 34252 34285 +33
==========================================
- Hits 28449 28358 -91
- Misses 5803 5927 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting how to test Panel apps is a great addition!
However, I would recommend splitting this into different how-tos. I believe most users should only be concerned with simple unit tests with Pytest. In its current form the how-to can lead users into an overly complicated path, specially beginners and non developers.
doc/how_to/test/test.md
Outdated
|
||
According to [locust-plugins](https://github.com/SvenskaSpel/locust-plugins) it should also be possible to possible to combine Locust and Playwright to test more advanced interactions. Unfortunately it does not work for me on Windows. You can check out the issue with code [here](https://github.com/SvenskaSpel/locust-plugins/issues/101#issuecomment-1367216919). | ||
|
||
### Test advanced interactions with Loadwright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this too alpha to be documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
There is no other way currently. And I also need it for other the next how to guides I plan to write on "performance optimization" and "dask". Loadwright is the only thing that can provide insights into the improved performance.
Real Load Testing of Panel data apps has really, really been missing. This is why the Bokeh/ Panel server still has performance issues. We have not been able to get insights and provide reproducible examples. This makes it possible. I've specifically pinned the version here. And its not more alpha than any new example or code contributed to Panel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying alpha as this is the disclaimer on the project's README.
Please note this project is at a very early stage an the api and functionality will change!
I would personally be hesitating when advised to depend on a project that states this, as it feels like it's still being built and that I'll have to change a lot of my code in the future.
Thanks for all the good comments. I've refactored. Please make a second review. Thanks. |
08c8872
to
ce0d783
Compare
ce0d783
to
cc54fe1
Compare
Thanks for your fixes. I've made a number of edits. One thing that would be nice is if you could re-record some of the gifs with a larger font size. You can do that any time and I'll upload the new versions. |
@philippjfr . The link https://assets.holoviz.org/panel/gifs/loadwright.gif used in the docs does not exist. Could you please upload the file? Thanks. |
Done |
I've increased the fontsize of the |
I've tested the how to guides manually twice and fixed any errors identified. I don't plan to do more unless told what to do :-) |
Closes #4243
You can preview the how to guides here
Issues experienced or identified during testing