Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to remove call to registered_names which no longer exists in bokeh #4939

Merged
merged 3 commits into from May 26, 2023

Conversation

alexmilowski
Copy link
Contributor

I'm really sure this is the correct change. It appears the IPyWidget is available like other things via Bokeh.Panel.IPyWidget

The issue is the use of registered_names generates a lot of JavaScript exceptions when we use things like the Tabulator.

@philippjfr
Copy link
Member

Thanks for the fix. Have to think about this a little more. To give a bit of background, Panel has two approaches for rendering IPyWidgets:

  1. When you're inside a notebook environment it uses the notebooks WidgetManager and will render itself using the Panel ipywidget model.
  2. When running on a server or when embedded in a website it instead uses the ipywidgets_bokeh implementation of a renderer.

So really this code should only check for the ipywidgets_bokeh model if we are in scenario 2.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #4939 (b838b3e) into main (0bc6499) will increase coverage by 10.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #4939       +/-   ##
===========================================
+ Coverage   73.38%   83.43%   +10.05%     
===========================================
  Files         270      270               
  Lines       38218    38221        +3     
===========================================
+ Hits        28046    31891     +3845     
+ Misses      10172     6330     -3842     
Flag Coverage Δ
ui-tests 40.88% <33.33%> (?)
unitexamples-tests 73.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/notebook.py 44.44% <100.00%> (+0.64%) ⬆️

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit a146aed into holoviz:main May 26, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants