Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive updates on reactive panes #4946

Merged
merged 2 commits into from May 26, 2023
Merged

Fix recursive updates on reactive panes #4946

merged 2 commits into from May 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4944

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #4946 (93f47dc) into main (bfe5aee) will increase coverage by 0.03%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #4946      +/-   ##
==========================================
+ Coverage   83.43%   83.47%   +0.03%     
==========================================
  Files         270      270              
  Lines       38218    38228      +10     
==========================================
+ Hits        31888    31910      +22     
+ Misses       6330     6318      -12     
Flag Coverage Δ
ui-tests 40.86% <11.11%> (-0.03%) ⬇️
unitexamples-tests 73.43% <94.44%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/base.py 87.09% <83.33%> (+4.30%) ⬆️
panel/tests/test_param.py 99.70% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 30e20af into main May 26, 2023
10 of 15 checks passed
@philippjfr philippjfr deleted the recursive_update branch May 26, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'param'
1 participant