Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controlling initial Template sidebar state #5033

Merged
merged 3 commits into from Jun 5, 2023
Merged

Conversation

philippjfr
Copy link
Member

Add initial_sidebar_state option to templates to allow controlling whether sidebar initializes as collapsed or expanded.

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #5033 (60518d4) into main (480e6b0) will increase coverage by 10.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5033       +/-   ##
===========================================
+ Coverage   73.40%   83.52%   +10.12%     
===========================================
  Files         271      271               
  Lines       38361    38667      +306     
===========================================
+ Hits        28157    32295     +4138     
+ Misses      10204     6372     -3832     
Flag Coverage Δ
ui-tests 40.67% <80.00%> (?)
unitexamples-tests 73.51% <80.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/template/base.py 78.79% <100.00%> (+0.08%) ⬆️
panel/template/slides/__init__.py 100.00% <100.00%> (ø)
panel/tests/ui/widgets/test_sliders.py 100.00% <100.00%> (+84.57%) ⬆️

... and 70 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr requested a review from maximlt June 5, 2023 08:28
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some minor comments, did you not implement GoldenTemplate intentionally?

panel/template/base.py Outdated Show resolved Hide resolved
examples/reference/templates/Bootstrap.ipynb Outdated Show resolved Hide resolved
examples/reference/templates/FastGridTemplate.ipynb Outdated Show resolved Hide resolved
examples/reference/templates/FastListTemplate.ipynb Outdated Show resolved Hide resolved
examples/reference/templates/Material.ipynb Outdated Show resolved Hide resolved
examples/reference/templates/React.ipynb Show resolved Hide resolved
examples/reference/templates/Vanilla.ipynb Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit b592e04 into main Jun 5, 2023
13 of 15 checks passed
@philippjfr philippjfr deleted the sidebar_collapsed branch June 5, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants