Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending FileInput: Add accept param #602

Merged
merged 3 commits into from Aug 21, 2019
Merged

Extending FileInput: Add accept param #602

merged 3 commits into from Aug 21, 2019

Conversation

DancingQuanta
Copy link
Contributor

@DancingQuanta DancingQuanta commented Aug 15, 2019 •
edited

Bokeh's FileInput have an attribute accept which is not passed through
panel so this PR will allow panel's FileInput to access accept
attribute. The accept attribute restrict FileInput to files with
specified extensions.

  • Add accept param
  • Add tests
  • Add docs

@DancingQuanta DancingQuanta marked this pull request as ready for review August 15, 2019 22:21
@DancingQuanta
Copy link
Contributor Author

I am done with this PR so it should be ready for review/merge.

@philippjfr
Copy link
Member

Thanks @DancingQuanta

@philippjfr philippjfr merged commit 4e1e01e into holoviz:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DancingQuanta @philippjfr