Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy now required dependency? #720

Closed
sdc50 opened this issue Oct 25, 2019 · 1 comment · Fixed by #723
Closed

Scipy now required dependency? #720

sdc50 opened this issue Oct 25, 2019 · 1 comment · Fixed by #723
Labels
type: bug Something isn't correct or isn't working

Comments

@sdc50
Copy link
Contributor

sdc50 commented Oct 25, 2019

The latest dev build of panel (panel-0.7.0a15-py_0) looks like it is trying to import scipy, but scipy is not among the required dependencies that are automatically installed through conda.

$ conda create -n panel -c pyviz/label/dev panel
...
$ conda activate panel
(panel) $ python
Python 3.7.4 (default, Aug 13 2019, 15:17:50) 
[Clang 4.0.1 (tags/RELEASE_401/final)] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import panel
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/__init__.py", line 6, in <module>
    from . import links # noqa
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/links.py", line 12, in <module>
    from .pane.holoviews import HoloViews, generate_panel_bokeh_map, is_bokeh_element_plot
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/pane/__init__.py", line 13, in <module>
    from .holoviews import HoloViews # noqa
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/pane/holoviews.py", line 20, in <module>
    from ..widgets import Player
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/widgets/__init__.py", line 12, in <module>
    from .misc import Audio, VideoStream # noqa
  File "/Users/rditlsc9/miniconda/envs/panel/lib/python3.7/site-packages/panel/widgets/misc.py", line 14, in <module>
    from scipy.io import wavfile
ModuleNotFoundError: No module named 'scipy'
@sdc50 sdc50 added the TRIAGE Default label for untriaged issues label Oct 25, 2019
@philippjfr philippjfr added type: bug Something isn't correct or isn't working and removed TRIAGE Default label for untriaged issues labels Oct 25, 2019
@philippjfr
Copy link
Member

That's poor review from me, this should not be imported at the top-level. I'll push a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants