Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CheckButtonGroup and similar selectors accept Parameterized objects as options #1793

Closed
CesarRodriguezPereira opened this issue Nov 17, 2020 · 0 comments · Fixed by #1795
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@CesarRodriguezPereira
Copy link

When dealing with selectors in panel, there's non uniform behaviour depending on what selector you're using.

As per the documentation, there's "a broad category of multi-value, option-selection widgets that provide a compatible API and include the MultiSelect, CrossSelector, CheckBoxGroup and CheckButtonGroup widgets". However, out of these widgets, 2 accept Param objects and 2 don't.

Both MultiSelect and CrossSelector accept param.Parameterized obects as options, labeling them as "ClassName instance.name", and returning the list of selected objects when calling ".value". However, CheckBoxGroup and CheckButtonGroup don't accept these objects as inputs, as they expect an element of List(String). This makes it so you can only use the names of objects directly when using these selectors, thus not having the entire object readily at your disposal when using them.

I think making CheckBoxGroup and CheckButtonGroup behave like MultiSelect already does would be great, affording users more flexibility on what to select, and providing uniformity to an API that's already documented as compatible.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Nov 18, 2020
@philippjfr philippjfr added this to the v0.10.2 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants