Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed tests for nested select. modified code to handle test cases. #5925

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

benbarn313
Copy link
Contributor

@benbarn313 benbarn313 commented Nov 27, 2023

Complete tests for nested_select

@hoxbro
Copy link
Member

hoxbro commented Nov 27, 2023

pre-commit.ci autofix

@ahuang11 ahuang11 self-requested a review November 27, 2023 16:36
@hoxbro
Copy link
Member

hoxbro commented Nov 27, 2023

You need to merge the latest main into the branch to get the package to build.

@hoxbro
Copy link
Member

hoxbro commented Nov 27, 2023

pre-commit.ci autofix

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (41d6b4f) 38.38% compared to head (9427768) 38.29%.
Report is 9 commits behind head on add_nested_select.

Files Patch % Lines
panel/widgets/select.py 14.06% 110 Missing ⚠️
panel/tests/widgets/test_select.py 13.72% 44 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           add_nested_select    #5925      +/-   ##
=====================================================
- Coverage              38.38%   38.29%   -0.09%     
=====================================================
  Files                    291      291              
  Lines                  42894    43073     +179     
=====================================================
+ Hits                   16465    16495      +30     
- Misses                 26429    26578     +149     
Flag Coverage Δ
ui-tests 38.29% <13.96%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11
Copy link
Contributor

Will add reference gallery in my branch.

@ahuang11 ahuang11 merged commit da8a854 into holoviz:add_nested_select Nov 27, 2023
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants