Add support for German tax id number [PAY-1199] #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhistheHolvi
force-pushed
the
muhis-steuerid-nummer
branch
from
9f2c2e1
to
de61bcd
Compare
| # First digit in the number should not be zero. | ||
| if number_list[0] == '0': | ||
| raise InvalidFormat() | ||
| # within the first ten digits one number has to appear exactly twice or |
There was a problem hiding this comment.
is this requirement specified somewhere in documentation?
There was a problem hiding this comment.
Wikipedia article mentioned in the module docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
German tax id number is one of the required identifiers that can be used by German freelancers to identify themselves.
Issue:
We don't have a validator for this number.
Solution:
Implement a validator.