Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/iPadOS 15] Hide QuckType bar #319

Closed
kkebo opened this issue Oct 3, 2021 · 14 comments · Fixed by #324
Closed

[iOS/iPadOS 15] Hide QuckType bar #319

kkebo opened this issue Oct 3, 2021 · 14 comments · Fixed by #324

Comments

@kkebo
Copy link
Contributor

kkebo commented Oct 3, 2021

In iOS/iPadOS 15, a-Shell displays the QuickType bar on the bottom.

F3A6C905-453A-47AF-B6F6-55C6BBAD7F3B

If I remember correctly, it was hidden in iOS/iPadOS 14.x and earlier.

Maybe, it relates to this:

In iOS 14 and iPadOS 14 and earlier, when autocorrectionType is set to UITextAutocorrectionTypeNo, the QuickType bar is disabled. For apps linked against iOS 15 and iPadOS 15 or later, the QuickType bar is enabled and shows spellchecking candidates. If the new behavior isn’t desirable for your use case, set spellCheckingType to UITextSpellCheckingTypeNo to hide the QuickType bar. (68874861)

@holzschu
Copy link
Owner

holzschu commented Oct 3, 2021

That's strange: I don't have this bar on my iPad (running iPadOS 15.0), with all the different keyboards I could try.

A WkWebView does not have the spellCheckingType property, so the advice on the linked page does not work. I'll keep investigating.

@kkebo
Copy link
Contributor Author

kkebo commented Oct 3, 2021

My environment:

  • 12.9-inch iPad Pro 5th generation
  • iPadOS 15.1 Developer Beta 2
  • a-Shel 1.7.6 (194)
  • Magic Keyboard (for iPad)
  • Keyboard settings:
    • F68F4F0D-D83A-4C9F-8B47-35EBAC803FAD

@kkebo
Copy link
Contributor Author

kkebo commented Oct 5, 2021

@holzschu It seems that you can't reproduce the problem if the Auto-Correction is disabled, so please check it. Also, after changing it, restarting the app is required.

AFF64A00-E841-4D39-86D5-E317628346DC

@kkebo
Copy link
Contributor Author

kkebo commented Oct 5, 2021

I believe that we need this workaround.

@holzschu
Copy link
Owner

holzschu commented Oct 5, 2021

Impressive workaround. I'll add it to a-Shell.

@holzschu
Copy link
Owner

holzschu commented Oct 6, 2021

Quick update: I still cannot reproduce the issue on my end, with or without Auto-Correction disabled. I have copied the workaround you linked into a-Shell, and it does not break at compilation or execution. It will be in build 197. If it works, I'll try to convert the objective-C code to Swift.

@kkebo
Copy link
Contributor Author

kkebo commented Oct 6, 2021

I still cannot reproduce the issue on my end, with or without Auto-Correction disabled.

Hmm, that's strange. After small tests, I found that the problem is depending on what keyboard I'm using. For instance, I can reproduce it when using "English (US)" keyboard, but can't when using "Japanese - Romaji" keyboard.

I have copied the workaround you linked into a-Shell, and it does not break at compilation or execution. It will be in build 197. If it works, I'll try to convert the objective-C code to Swift.

Thank you.

@kkebo
Copy link
Contributor Author

kkebo commented Oct 7, 2021

I tried a-Shell 1.7.6 (197), but the workaround didn't work unfortunately.

@holzschu
Copy link
Owner

holzschu commented Oct 7, 2021

That's good to know, thanks (even if it's bad news).
I also received a report that it actually made the QuickType bar appear in settings were it was not appearing before (so, at least, I have proof that it does something...)

I'm going to remove that file, and let's hope Apple fixes the many issues with WkWebView on iOS 15...

@kkebo
Copy link
Contributor Author

kkebo commented Oct 7, 2021

By the way, could you share the file you added to try to fix the problem?

I want to look into it a bit more.

@holzschu
Copy link
Owner

holzschu commented Oct 7, 2021

Here you are, and thanks for the help. The repository is behind the distributed version, but it should be working.
Archive.zip

@kkebo
Copy link
Contributor Author

kkebo commented Oct 7, 2021

Thank you so much. If I find a workaround that works, I'll send a PR.

@kkebo
Copy link
Contributor Author

kkebo commented Oct 10, 2021

Hi @holzschu, I've confirmed that the workaround would work well, so I sent a PR #324.

@kkebo
Copy link
Contributor Author

kkebo commented Oct 12, 2021

Thank you for merging my PR. In a-Shell 1.7.6 (199) (TestFlight), the problem has finally been solved at least on my environment.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants